Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: add SameType AO #3408

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Editorial: add SameType AO #3408

merged 1 commit into from
Sep 5, 2024

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Aug 28, 2024 •
edited
Loading

Per editor call discussion.

Related: #3339.

@ljharb ljharb requested a review from a team August 28, 2024 22:14
@ljharb ljharb mentioned this pull request Aug 28, 2024
Closed
ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 28, 2024
@ljharb
Editorial: add SameType AO (tc39#3408)
b07936c
ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 28, 2024
@ljharb
Editorial: add SameType AO (tc39#3408)
1d5cb78
michaelficarra
michaelficarra reviewed Aug 28, 2024
View reviewed changes
spec.html Outdated Show resolved Hide resolved
michaelficarra
michaelficarra reviewed Aug 28, 2024
View reviewed changes
spec.html Outdated Show resolved Hide resolved
ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 29, 2024
@ljharb
Editorial: add SameType AO (tc39#3408)
b606011
@ljharb ljharb requested review from michaelficarra and a team August 29, 2024 02:32
michaelficarra
michaelficarra approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 29, 2024
@ljharb
Editorial: add SameType AO (tc39#3408)
221a934
@ljharb ljharb requested a review from a team August 29, 2024 16:12
@ljharb ljharb added the editor call to be discussed in the next editor call label Sep 5, 2024
@michaelficarra michaelficarra added ready to merge Editors believe this PR needs no further reviews, and is ready to land. and removed editor call to be discussed in the next editor call labels Sep 5, 2024
@ljharb ljharb merged commit f4d28eb into tc39:main Sep 5, 2024
8 checks passed
@ljharb ljharb deleted the same-type branch September 5, 2024 22:29
@michaelficarra michaelficarra mentioned this pull request Sep 19, 2024
Merged
@michaelficarra michaelficarra mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

@syg syg syg approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljharb @syg @michaelficarra