Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: add a ReturnCompletion AO, mirroring NormalCompletion/ThrowCompletion #3415

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Editorial: add a ReturnCompletion AO, mirroring NormalCompletion/ThrowCompletion #3415

merged 2 commits into from
Sep 23, 2024

Conversation

michaelficarra
Copy link
Member

There were 13 of these, so it seemed enough to justify an AO like we have for NormalCompletion (31) and ThrowCompletion (15).

@ljharb ljharb requested a review from a team September 4, 2024 21:37
@bakkot bakkot mentioned this pull request Sep 4, 2024
Merged
@bakkot
Copy link
Contributor

bakkot commented Sep 4, 2024

Will need tc39/ecmarkup#605 upstreamed to work correctly.

@bakkot
Copy link
Contributor

bakkot commented Sep 4, 2024

Pushed the ecmarkup bump to this branch.

bakkot
bakkot reviewed Sep 4, 2024
View reviewed changes
spec.html Show resolved Hide resolved
@jmdyck
Copy link
Collaborator

jmdyck commented Sep 5, 2024

In 5.2.3.5 Implicit Normal Completion, you should probably add ReturnCompletion after ThrowCompletion.

@michaelficarra
Copy link
Member Author

@bakkot @jmdyck Thanks for the reviews. Updated.

@michaelficarra michaelficarra requested a review from a team September 6, 2024 00:15
syg
syg approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Sep 20, 2024
@ljharb ljharb merged commit 7df8f59 into main Sep 23, 2024
9 checks passed
@ljharb ljharb deleted the ReturnCompletion branch September 23, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

@syg syg syg approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelficarra @bakkot @jmdyck @syg @ljharb