Editorial: Quick fixes for CreateListFromArrayLike #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Sep 6, 2024
michaelficarra
approved these changes
Sep 6, 2024
|
@ljharb Could you please change this back to a 2-state enum? Michael talked about changing it to a boolean but I didn't think that was actually being changed. I still prefer the enum to a bool. |
- When an operation has an optional parameter X,
the op doesn't do anything with X until either:
- it has established that a value was passed to X, or
- it has established that a value wasn't passed to X,
and has set X to some value.
ljharb
force-pushed
the
quick_fixes_7
branch
from
401529b
to
92aa8e0
Compare
michaelficarra
approved these changes
Sep 6, 2024
michaelficarra
added
the
ready to merge
|
Passes my checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capital 'B' on "Boolean"
When an operation has an optional parameter X, the op doesn't do anything with X until either: