Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: use dot notation for internal methods #595

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Jun 3, 2016

Specifically, change 19 occurrences of

the [[Foo]] internal method of _O_

and 2 of

_O_'s [[Foo]] internal method

to

_O_.[[Foo]]

and 2 occurrences of

calling the [[Get]] internal method of _obj_ with argument _j_

to

calling _obj_.[[Get]](_j_)

(Split off from #591.)

@bterlson
Copy link
Member

bterlson commented Jun 3, 2016

I guess this commit includes some previous commits that I squashed into master (should have not squashed it in hindsight, but too late now). You can fix this by either rebasing this branch on top of master or, if there are conflicts, cherry-picking 000be90 on top of master and resetting dots_for_internal_methods to that new commit (or delete that branch and recreate it).

@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from 000be90 to 6b346db Compare June 3, 2016 21:20
@jmdyck
Copy link
Collaborator Author

jmdyck commented Jun 3, 2016

Rebased to master (though the process was a bit messy).

@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from 6b346db to 3e34baa Compare June 7, 2016 20:26
@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from 3e34baa to b8efe7d Compare June 9, 2016 20:35
@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from b8efe7d to ba16821 Compare July 6, 2016 20:46
@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from ba16821 to 8215f2d Compare July 26, 2016 22:05
@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from 8215f2d to cf8139c Compare August 22, 2016 19:30
@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from cf8139c to d207bf8 Compare September 16, 2016 21:12
@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from d207bf8 to 42b9106 Compare September 30, 2016 01:49
@jmdyck jmdyck force-pushed the dots_for_internal_methods branch 2 times, most recently from e3a3526 to 12e0593 Compare November 15, 2016 19:09
@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from 12e0593 to ac2c032 Compare December 13, 2016 06:04
@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from ac2c032 to cab28cc Compare December 22, 2016 03:05
Specifically, change 19 occurrences of
    the [[Foo]] internal method of _O_
and 2 of
    _O_'s [[Foo]] internal method
to
    _O_.[[Foo]]

and 2 occurrences of
    calling the [[Get]] internal method of _obj_ with argument _j_
to
    calling _obj_.[[Get]](_j_)
@jmdyck jmdyck force-pushed the dots_for_internal_methods branch from cab28cc to bac3339 Compare December 30, 2016 22:48
@bterlson bterlson merged commit 8ec2af4 into tc39:master Feb 2, 2017
@jmdyck jmdyck deleted the dots_for_internal_methods branch February 13, 2018 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants