Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Change If X is not undefined #472

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Editorial: Change If X is not undefined #472

merged 4 commits into from
Jul 8, 2020

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Jul 8, 2020 •
edited
Loading

Reduce double negative in the spec.

See also #458

@FrankYFTang
EDITORIAL: Change If X is not undefined
a32fabb 
Reduce double negative in the spec.
@FrankYFTang
Change If X is not undefined A else B
f69e5cc 
Change from
If X is not undefined A else B
to
If X is undefined B else A
@FrankYFTang
Change If X is not undefined then A else B
1edd149 
Change 
If X is not undefined then A else B
to
If X is undefined then B else A
@FrankYFTang
correct casing
4be621e
@FrankYFTang FrankYFTang changed the title EDITORIAL: Change If X is not undefined Editorial Change If X is not undefined Jul 8, 2020
@FrankYFTang FrankYFTang changed the title Editorial Change If X is not undefined Editorial: Change If X is not undefined Jul 8, 2020
leobalter
leobalter approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@leobalter leobalter merged commit 7f83b8a into master Jul 8, 2020
@leobalter leobalter deleted the FrankYFTang-patch-5 branch July 8, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leobalter leobalter leobalter approved these changes

@sffc sffc sffc approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@gibson042 gibson042 Awaiting requested review from gibson042

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrankYFTang @leobalter @sffc @ryzokuken