-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: use dotted intrinsic form #474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since tc39/ecma262#1376, the dotted form of intrinsic notation is preferred. Additionally, tc39/ecma262#2056 intends to remove these legacy intrinsics, once it is non-normative to do so. HTML has already been updated to no longer use them.
ryzokuken
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Should we have some sort of linting to ensure all that trailing whitespace wouldn't have existed in the first place?
I think you missed to update |
@anba oops, thanks. updated! |
leobalter
approved these changes
Aug 21, 2020
ben-allen
added a commit
to ben-allen/proposal-intl-duration-format
that referenced
this pull request
Nov 6, 2024
…insic form. See: tc39/ecma402#843 (prefix names of intrinsics) tc39/ecma402#474 (dotted intrinsic form)
ben-allen
added a commit
to ben-allen/proposal-intl-duration-format
that referenced
this pull request
Nov 6, 2024
…insic form. See: tc39/ecma402#843 (prefix names of intrinsics) tc39/ecma402#474 (dotted intrinsic form)
ryzokuken
pushed a commit
to tc39/proposal-intl-duration-format
that referenced
this pull request
Nov 12, 2024
…insic form. See: tc39/ecma402#843 (prefix names of intrinsics) tc39/ecma402#474 (dotted intrinsic form)
ben-allen
added a commit
to ben-allen/proposal-intl-duration-format
that referenced
this pull request
Nov 13, 2024
…ed intrinsic form. See: tc39/ecma402#843 (prefix names of intrinsics) tc39/ecma402#474 (dotted intrinsic form)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tc39/ecma262#1376, the dotted form of intrinsic notation is preferred.
Additionally, tc39/ecma262#2056 intends to remove these legacy intrinsics, once it is non-normative to do so. HTML has already been updated to no longer use them.
I did not delete the legacy ones from "conventions.html" yet, and I don't think that should happen until tc39/ecma262#1948 is resolved (otherwise, removing items from that table is normative).