Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Change the hourCycle default logic #758

Merged
merged 8 commits into from
Sep 27, 2023
Merged

Normative: Change the hourCycle default logic #758

merged 8 commits into from
Sep 27, 2023

Commits on Mar 13, 2023

  1. Normative: Change the hourCycle default logic 

    While hour12 is either true or false, let hourCycle to be either 'h12' or 'h23' but not 'h11' nor 'h24'.

The current logic is not reasonable. We see no region in the CLDR use h11 nor h24 hour cycle as default. 
While we set a hour12: true on a 24 hour system region (which use 0:00 - 23:59), we should set to h12 instead of h11

Do not perform the starnge logic of setting default hourCycle based on both hour12 and the defaultHourCycle while hour12 is true or false. Instead, only depends on hour12 to set it to h12 or h23. 

Address #402
    @FrankYFTang
    FrankYFTang authored Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d39f03a View commit details
    Browse the repository at this point in the history

  2. simplified

    @FrankYFTang
    FrankYFTang authored Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e154537 View commit details
    Browse the repository at this point in the history

  3. address ja case

    @FrankYFTang
    FrankYFTang authored Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ca8280a View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. rework to anba'suggestion

    @FrankYFTang
    FrankYFTang authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    b7ef7da View commit details
    Browse the repository at this point in the history

  2. Update spec/datetimeformat.html 

    Co-authored-by: Shane F. Carr <sffc@google.com>
    @FrankYFTang @sffc
    FrankYFTang and sffc authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    3d550bf View commit details
    Browse the repository at this point in the history

  3. Update spec/datetimeformat.html 

    Co-authored-by: Shane F. Carr <sffc@google.com>
    @FrankYFTang @sffc
    FrankYFTang and sffc authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    5eac65b View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Update spec/datetimeformat.html 

    Co-authored-by: André Bargull <andre.bargull@gmail.com>
    @ryzokuken @anba
    ryzokuken and anba authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    66ab756 View commit details
    Browse the repository at this point in the history

  2. Update spec/datetimeformat.html 

    Co-authored-by: André Bargull <andre.bargull@gmail.com>
    @ryzokuken @anba
    ryzokuken and anba authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    dfde222 View commit details
    Browse the repository at this point in the history