Add visitor #66
Merged
Add visitor #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, the "prevents parsing lists which mix the two" bit actually does break tests. I'm not sure what the right behavior is here. Edit: just reverted back to the original behavior for now. |
michaelficarra
approved these changes
May 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a basic visitor under
visitor.ts.It also splits the ordered and unordered list item types and prevents parsing lists which mix the two (which was presumably a bug, though I haven't added a test).Not anymore; apparently that was intentional. Not entirely what we want to do here - probably allow mixing, and lint against it.Based on #59 and marked as a draft until that PR is landed.Edit: ready to go.