Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tag parsing #92

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Fix tag parsing #92

merged 2 commits into from
Jul 7, 2022

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jul 5, 2022

The tag regex didn't recognize attributes with -s, as in <emu-meta suppress-effects="foo">.

Also exports the FragmentNode type, which was just an oversight, and bumps minor version. Please rebase, not squash.

@bakkot bakkot mentioned this pull request Jul 5, 2022
Merged
@bakkot bakkot merged commit 1bd6f2e into main Jul 7, 2022
@bakkot bakkot deleted the tag-parsing branch July 7, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bakkot @michaelficarra