Don't autolink inside a tags (fixes #88)

tc39 · Apr 29, 2016 · 0fadc4a · 0fadc4a
1 parent 29712f5
commit 0fadc4a
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 3 deletions.
diff --git a/lib/Spec.js b/lib/Spec.js
@@ -225,7 +225,7 @@ module.exports = class Spec {
       if (!classAttr) continue;
 
       const lang = classAttr.replace(/lang(uage)?\-/, '');
-      let input = codes[i].textContent
+      let input = codes[i].textContent;
 
       // remove leading and trailing blank lines
       input = input.replace(/^(\s*[\r\n])+|([\r\n]\s*)+$/g, '');

diff --git a/lib/autolinker.js b/lib/autolinker.js
@@ -1,7 +1,22 @@
 'use strict';
 const escape = require('html-escape');
 const utils = require('./utils');
-const NO_CLAUSE_AUTOLINK = ['PRE', 'CODE', 'EMU-CLAUSE', 'EMU-PRODUCTION', 'EMU-GRAMMAR', 'EMU-XREF', 'H1', 'H2', 'H3', 'H4', 'H5', 'H6', 'EMU-EQN', 'EMU-ALG', 'EMU-VAR', 'EMU-VAL', 'VAR'];
+const NO_CLAUSE_AUTOLINK = [
+  'PRE',
+  'CODE',
+  'EMU-CLAUSE',
+  'EMU-PRODUCTION',
+  'EMU-GRAMMAR',
+  'EMU-XREF',
+  'H1', 'H2', 'H3', 'H4', 'H5', 'H6',
+  'EMU-EQN',
+  'EMU-ALG',
+  'EMU-VAR',
+  'EMU-VAL',
+  'VAR',
+  'A'
+];
+
 const clauseTextNodesUnder = utils.textNodesUnder(NO_CLAUSE_AUTOLINK);
 
 exports.link = function(spec) {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ecmarkup",
-  "version": "3.2.1",
+  "version": "3.2.2",
   "description": "Custom element definitions and core utilities for markup that specifies ECMAScript and related technologies.",
   "main": "lib/ecmarkup.js",
   "scripts": {

diff --git a/test/autolinking.html b/test/autolinking.html
@@ -17,4 +17,5 @@ <h1>Autolinking 2</h1>
   <p>Strict mode shoud link. But Scrict Mode should not.</p>
   <p>%Percent% should autolink.</p>
   <p>Vars to dfns should be vars not dfns: _Lowercase_.</p>
+  <p>Also, no autolinks in <a href="#">anchors: Lowercase</a>.</p>
 </emu-clause>
diff --git a/test/autolinking.html.baseline b/test/autolinking.html.baseline
@@ -15,5 +15,6 @@
   <p><emu-xref href="#sec-foo"><a href="#sec-foo">Strict mode</a></emu-xref> shoud link. But Scrict Mode should not.</p>
   <p><emu-xref href="#sec-foo"><a href="#sec-foo">%Percent%</a></emu-xref> should autolink.</p>
   <p>Vars to dfns should be vars not dfns: <var>Lowercase</var>.</p>
+  <p>Also, no autolinks in  <a href="#">anchors: Lowercase</a>.</p>
 </emu-clause>
 </body>