make declaration rule slightly more strict

tc39 · Aug 3, 2023 · d9df38b · d9df38b
1 parent db6d01c
commit d9df38b
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/src/lint/rules/variable-use-def.ts b/src/lint/rules/variable-use-def.ts
@@ -68,17 +68,15 @@ class Scope {
     mayBeShadowed: boolean = false
   ): void {
     if (this.declared(name)) {
-      if (!mayBeShadowed) {
-        for (const scope of this.strictScopes) {
-          if (scope.has(name)) {
-            this.report({
-              ruleId: 're-declaration',
-              message: `${JSON.stringify(name)} is already declared`,
-              line: nameNode!.location.start.line,
-              column: nameNode!.location.start.column,
-            });
-            return;
-          }
+      for (const scope of this.strictScopes) {
+        if (scope.has(name)) {
+          this.report({
+            ruleId: 're-declaration',
+            message: `${JSON.stringify(name)} is already declared`,
+            line: nameNode!.location.start.line,
+            column: nameNode!.location.start.column,
+          });
+          return;
         }
       }
     } else {