fix some markEffects bugs (#430)

tc39 · Apr 1, 2022 · e528ac0 · e528ac0
1 parent 852e2f2
commit e528ac0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Meta.ts b/src/Meta.ts
@@ -36,7 +36,7 @@ export default class Meta extends Builder {
   static render(spec: Spec, node: HTMLElement) {
     // This builder turns <emu-meta> tags that aren't removed during effect
     // propagation on invocations into <span>s so they are rendered.
-    if (node.hasAttribute('effects')) {
+    if (node.hasAttribute('effects') && spec.opts.markEffects) {
       const classNames = node
         .getAttribute('effects')!
         .split(',')

diff --git a/src/cli.ts b/src/cli.ts
@@ -102,13 +102,15 @@ const build = debounce(async function build() {
       extraBiblios: [],
       toc: !args['no-toc'],
       oldToc: !!args['old-toc'],
-      markEffects: !!args['mark-effects'],
       lintSpec: !!args['lint-spec'],
       assets: args.assets as 'none' | 'inline' | 'external',
     };
     if (args.verbose) {
       opts.log = utils.logVerbose;
     }
+    if (args['mark-effects']) {
+      opts.markEffects = true;
+    }
     let warned = false;
 
     for (let toResolve of args['load-biblio'] ?? []) {