rephrase algorithm lint rules in terms of parsed lines #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm lint rules were written before the addition of the expression parser in #464.
The expression parser is smarter than the bare ecmarkdown parser, particularly around the handling of
<ins>/<del>(specifically, it silently inlines the contents of<ins>and discards the contents of<del>[as of #494] so that you're linting against the intended spec text). By rewriting the algorithm lint rules in terms of the expression parser, we get correct handling of<ins>/<del>for free. That also lets us rip out some gross and incomplete logic for handling<ins>/<del>fromalgorithm-line-style.ts.The expression parser wasn't surfacing location information, and had an annoying intermediate node type, so it needed to be tweaked too.