Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match synthesized selectable counter markers to the context list #504

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Match synthesized selectable counter markers to the context list #504

merged 4 commits into from
Jan 18, 2023

Conversation

gibson042
Copy link
Contributor

Fixes #503

@gibson042 gibson042 requested a review from bakkot January 11, 2023 02:28
@bakkot bakkot force-pushed the gh-503-synthesized-list-markers branch from 730cb78 to cc50a35 Compare January 18, 2023 07:05
bakkot
bakkot approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works locally, and thanks for doing the work of implementing these correctly instead of just hardcoding a few cases like I did.

@bakkot bakkot merged commit 69a13fb into tc39:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synthesized counter markers are incorrect for replaced steps
2 participants
@gibson042 @bakkot