remove --js-out/--css-out; replace with --assets-dir #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
commented
Aug 12, 2023
| if (this.opts.multipage) { | ||
| await this.buildMultipage(wrapper, commonEles, jsSha); | ||
| await this.buildMultipage(wrapper, commonEles); |
There was a problem hiding this comment.
To explain the change to do buildAssets before buildMultipage:
buildMultipage makes a copy of the document as it exists when buildMultipage is invoked. Previously we were inserting ecmarkup.js etc separately for the two kinds of output: we'd add script src='../ecmarkup.js' in buildMultipage, and then later add script src='ecmarkup.js' in buildAssets.
Now we put all assets in the single-page version initially and then rewrite those references in the copy in buildMultipage like we rewrite any other reference.
michaelficarra
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change. It significantly simplifies things as we introduce more assets, e.g. in #539.
Had to update typescript to fix some issues with the older version, which required some other related changes. I suggest reviewing commits individually.