Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better completion regex #558

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Better completion regex #558

merged 2 commits into from
Nov 1, 2023

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Nov 1, 2023

Regex change is necessary for tc39/ecma262#3163 to land.

The change to the regexp is

  • to make it so that only "throw a" as in "throw a TypeError exception" counts, so that a reference to a "throw completion" isn't interpreted as throwing,
  • to make "Return Completion Record { ... }" count as returning a completion record, and
  • to distinguish between a reference to a "return completion" and a step which says to "Return Completion (...)".

@bakkot bakkot requested a review from michaelficarra November 1, 2023 04:54
@bakkot bakkot force-pushed the better-completion-regex branch from fe673f6 to 00aff13 Compare November 1, 2023 05:12
src/Algorithm.ts Outdated Show resolved Hide resolved
@bakkot bakkot force-pushed the better-completion-regex branch from 53bb055 to 0e8b7d2 Compare November 1, 2023 22:46
@bakkot bakkot merged commit e319ccd into main Nov 1, 2023
2 checks passed
@bakkot bakkot deleted the better-completion-regex branch November 1, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants