-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #81: support ins/del diff styles for table rows #82
Conversation
I added support for lists as well. Some related information from the HTML specification (basically saying ins/del are incompatible with tables and lists): |
-1. You should not mark these up with unsemantic .del and .ins classes. You should use |
@domenic Sorry, but HTML's not expressive enough for us here (without potentially some huge hoop-jumping). You simply can't reproduce the same aesthetic with edit: See my usage here for comparison: http://tc39.github.io/Function-prototype-toString-revision/#sec-ecmascript-function-objects |
I don't understand why your usage can't just use my technique. |
@domenic I'm trying to encode the information that the entire row was added, as well as allow ecmarkup to style that row in a way that makes it clear to humans. See the difference in appearance between my linked example and yours. I can't do that without a class on the |
I think it's pretty clear that in my example an entire row was added. |
See conversation at tc39#82 (comment).
@domenic I've added the style reset to |
Sorry I didn't see a notification for this PR anywhere :( Am I even watching my own repo?? Anyway, I think this is fine. Long term I hope diff tools like aria's will make manual ins/del less used. But for now it seems ok to add some authoring conveniences even though it's not as ideal as it could be. |
Fixes #81. 🚣 🌈