Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

test262 tests #5

Closed
michaelficarra opened this issue Jan 25, 2018 · 5 comments
Closed

test262 tests #5

michaelficarra opened this issue Jan 25, 2018 · 5 comments

Comments

@michaelficarra
Copy link
Member

Tests should be added to https://github.com/tc39/test262/tree/master/test/built-ins/Symbol

@gsathya
Copy link
Member

gsathya commented Jun 6, 2018

@michaelficarra are you planning on adding test262 tests for this?

@joyeecheung is implementing this in V8 now and we'd like test262 tests before we ship.

@michaelficarra
Copy link
Member Author

Yeah, I had forgotten about this. I'll try to get around to it some time this week. Also, this might be a good opportunity for new contributors.

@joyeecheung
Copy link

I'd be happy to try working on the tests!

@michaelficarra
Copy link
Member Author

@joyeecheung Cool! I am awaiting your PR. Let me know if you need help. Remember to test the missing description case.

@michaelficarra
Copy link
Member Author

Fixed by tc39/test262#1590. Thanks @joyeecheung.

@ljharb ljharb mentioned this issue Aug 29, 2018
19 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants