This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Normative: Define private names at the beginning of the class #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Private names are logically defined during the whole class execution, not only after the definition is reached. This patch properly hoists the private name definition, to avoid an unintentional and confusing TDZ condition. Closes #263
littledan
added a commit
to tc39/proposal-private-methods
that referenced
this pull request
Sep 13, 2019
Rebase of this repository on tc39/proposal-class-fields#269
littledan
added a commit
to tc39/proposal-static-class-features
that referenced
this pull request
Sep 13, 2019
Rebase of this repository on tc39/proposal-class-fields#269
|
lgtm |
ljharb
approved these changes
Sep 13, 2019
syg
approved these changes
Sep 13, 2019
|
We reached consensus on this PR in the October 2019 TC39. |
joyeecheung
added a commit
to joyeecheung/test262
that referenced
this pull request
Oct 4, 2019
leobalter
pushed a commit
to tc39/test262
that referenced
this pull request
Oct 8, 2019
caiolima
added a commit
to caiolima/webkit
that referenced
this pull request
Oct 11, 2019
definition. This aligns the implementation with the specification change done in tc39/proposal-class-fields#269. It is necessary to create and add Private symbols during the inital phase of class definition, because computed properties can try to access a private member. In this case, we need to fail with TypeError because it is an access to a not installed private field.
littledan
added a commit
to tc39/proposal-static-class-features
that referenced
this pull request
Jan 2, 2020
Rebase of this repository on tc39/proposal-class-fields#269
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private names are logically defined during the whole class execution,
not only after the definition is reached. This patch properly hoists
the private name definition, to avoid an unintentional and confusing
TDZ condition.
Closes #263