This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Check for undeclared private names in eval-scripts after parsing #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing runtime types like execution contexts isn't allowed during parsing, therefore we need to defer the undeclared private names check for eval-scripts. EvalDeclarationInstantiation seems like the obvious choice, because it already contains checks for duplicate lexicals in non-strict eval-scripts.
|
This phrasing is a real improvement. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing runtime types like execution contexts isn't allowed during parsing,
therefore we need to defer the undeclared private names check for eval-scripts.
EvalDeclarationInstantiation seems like the obvious choice, because it already
contains checks for duplicate lexicals in non-strict eval-scripts.
I've also changed |Script : ScriptBody?| to |ScriptBody : StatementList|, and |Module : ModuleBody?| to |ModuleBody : ModuleItemList| because ScriptBody resp. ModuleBody are both optional productions, so their parse nodes may not be present.