Normative: Remove errant ToPrimitive #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this ToPrimitive call is a relic from back when PrivateName was a primitive type. Now that it's an object, and toString() throws, the result would be that an exception would be thrown on this line. Furthermore, it's redundant given the following ToPropertyKey call. This patch simply removes the ToPrimitive operation.
nicolo-ribaudo
approved these changes
Oct 30, 2018
| @@ -783,7 +783,6 @@ <h1>ToElementDescriptor ( _elementObject_ )</h1> | |||
| 1. Let _kind_ be ? ToString(? Get(_elementObject_, `"kind"`)). | |||
| 1. If _kind_ is not one of `"method"` or `"field"`, throw a *TypeError* exception. | |||
| 1. Let _key_ be ? Get(_elementObject_, `"key"`). | |||
| 1. Set _key_ to ? ToPrimitive(_key_, hint String). | |||
| 1. If _key_ has a [[PrivateName]] internal slot, set _key_ to _key_.[[PrivateName]]. | |||
| 1. Otherwise, set _key_ to ? ToPropertyKey(_key_). | |||
There was a problem hiding this comment.
(Note for anyone reading this PR)
ToPropertyKey calls ToPrimitive
|
I haven't heard any concerns about this bug fix, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this ToPrimitive call is a relic from back when PrivateName
was a primitive type. Now that it's an object, and toString() throws,
the result would be that an exception would be thrown on this line.
Furthermore, it's redundant given the following ToPropertyKey call.
This patch simply removes the ToPrimitive operation.