Normative: Renamings in decorator descriptors #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For hooks, rename to start For fields, rename to initialize Keep the internal slot [[Initializer]], as class fields uses that name
As discussed in #173
|
We may want to consider the interaction of “hook” with the upcoming React feature. |
|
@ljharb - It's a really generic term, I don't think there's a problem there. But there's always... |
|
I think hook is the best we’ve come up with so far, just wanted to mention the overlap :-) |
pabloalmunia
approved these changes
Jan 10, 2019
|
I guess react hooks don't ever use the term "hook" in source code, so maybe we're good here. Let's go with "hook" for now, and we can reconsider it in future issues. |
This was referenced Jan 11, 2019
This was referenced Feb 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #173
See individual commit messages for details.