Skip to content

Commit

Permalink
editorial: feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
guybedford committed Nov 22, 2024
1 parent e25dddf commit 01e42c7
Showing 1 changed file with 12 additions and 13 deletions.
25 changes: 12 additions & 13 deletions spec.emu
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ contributors: Luca Casonato, Guy Bedford
1. <ins>If _specifier_ is an Object, then</ins>
1. <ins>Let _moduleSource_ be GetModuleSourceModuleRecord(_specifier_).</ins>
1. <ins>If _moduleSource_ is not ~not-a-source~, then</ins>
1. <ins>If _moduleSource_.[[Realm]] is not equal to the current Realm Record, then</ins>
1. <ins>If _moduleSource_.[[Realm]] is not the current Realm Record, then</ins>
1. <ins>Perform ! Call(_promiseCapability_.[[Reject]], *undefined*, « a newly created *TypeError* object »).</ins>
1. <ins>Return _promiseCapability_.[[Promise]].</ins>
1. <ins>Let _attributesObj_ be Completion(Get(_options_, *"with"*)).</ins>
Expand Down Expand Up @@ -974,7 +974,7 @@ contributors: Luca Casonato, Guy Bedford
<ins>ModuleSourcesEqual(_otherModuleRecord_)</ins>
</td>
<td>
<p><ins>For Module Records that implement a normal completion for GetModuleSource(), allows defining a source equality operation for host registry checks.</ins></p>
<p><ins>For Module Records that return a normal completion for GetModuleSource(), allows defining a source equality operation for host registry checks.</ins></p>
<p><ins>For Module Records that do not have a source representation, ModuleSourcesEqual() is never called.</ins></p>
</td>
</tr>
Expand All @@ -983,7 +983,7 @@ contributors: Luca Casonato, Guy Bedford
<ins>GetModuleSourceName()</ins>
</td>
<td>
<p><ins>For Module Records that implement a normal completion for GetModuleSource(), returns a constant String for each concrete module record that exposes a source representation through `GetModuleSource()`, to be provided in the strongly branded return value of the @@toStringTag getter on %AbstractModuleSource%.</ins></p>
<p><ins>For Module Records that return a normal completion for GetModuleSource(), returns a constant String for each concrete module record that exposes a source representation through `GetModuleSource()`, to be provided in the strongly branded return value of the @@toStringTag getter on %AbstractModuleSource%.</ins></p>
<p><ins>For Module Records that do not have a source representation, GetModuleSourceName() is never called.</ins></p>
</td>
</tr>
Expand Down Expand Up @@ -1014,10 +1014,10 @@ contributors: Luca Casonato, Guy Bedford
<ins>[[SourceText]]</ins>
</td>
<td>
<ins>a sequence of Unicode code points</ins>
<ins>ECMAScript source text</ins>
</td>
<td>
<ins>The original <emu-xref href="#sec-source-text">source text</emu-xref> for this module, allowing for equality checks and serialization of module sources. Hosts may implement this field with any optimized representation that supports equality and serialization.</ins>
<ins>The original <emu-xref href="#sec-source-text">source text</emu-xref> for this module, allowing for equality checks and serialization of module sources.</ins>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -1061,7 +1061,7 @@ contributors: Luca Casonato, Guy Bedford
<ins>an Object or ~empty~</ins>
</td>
<td>
<ins>The Module Source Object generated by GetModuleSource().</ins>
<ins>The Module Source Object generated by GetModuleSource(). Empty when no Module Source Object has yet been associated with this module.</ins>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -1197,7 +1197,7 @@ contributors: Luca Casonato, Guy Bedford
</dl>
<emu-alg>
1. <ins>If _otherModule_ is not a Source Text Module Record, return *false*.</ins>
1. <ins>If _otherModule_.[[SourceText]] is equal to _module_.[[SourceText]], return *true*.</ins>
1. <ins>If _otherModule_.[[SourceText]] is _module_.[[SourceText]], return *true*.</ins>
1. <ins>Return *false*.</ins>
</emu-alg>
</emu-clause>
Expand Down Expand Up @@ -1306,7 +1306,7 @@ contributors: Luca Casonato, Guy Bedford
<h1>
<ins>
GetModuleSourceModuleRecord (
_moduleSource_: an Object,
_specifier_: an Object,
): either a Module Record or ~not-a-source~
</ins>
</h1>
Expand All @@ -1317,13 +1317,13 @@ contributors: Luca Casonato, Guy Bedford

<emu-alg>
1. Let _module_ be *undefined*.
1. If _moduleSource_ has a [[SourceTextModuleRecord]] internal slot, then
1. Set _module_ to _moduleSource_.[[SourceTextModuleRecord]].
1. If _specifier_ has a [[SourceTextModuleRecord]] internal slot, then
1. Set _module_ to _specifier_.[[SourceTextModuleRecord]].
1. Else,
1. Set _module_ to HostGetModuleSourceModuleRecord(_moduleSource_).
1. Set _module_ to HostGetModuleSourceModuleRecord(_specifier_).
1. If _module_ is ~not-a-source~, return ~not-a-source~.
1. Assert: _module_ is a concrete Module Record.
1. Assert: If _module_ is a Source Text Module Record, then _module_.[[ModuleSource]] is equal to _moduleSource_.
1. Assert: If _module_ is a Source Text Module Record, then _module_.[[ModuleSource]] is _specifier_.
1. Return _module_.
</emu-alg>
</emu-clause>
Expand Down Expand Up @@ -1421,7 +1421,6 @@ contributors: Luca Casonato, Guy Bedford
<ul>
<li>is %ModuleSource%.</li>
<li>does not have a global name or appear as a property of the global object.</li>
<li>will throw an error when invoked, where support for dynamic construction may be added in future.</li>
</ul>

<emu-clause id="sec-modulesource">
Expand Down

0 comments on commit 01e42c7

Please sign in to comment.