Normative: turn useGrouping false for hours & smaller units when style is 2-digits or numeric #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
approved these changes
Apr 25, 2024
ryzokuken
approved these changes
Apr 29, 2024
ben-allen
added
consensus
|
I have problem to update this PR to the latest spec text. The spec text got heavily changed by @ben-allen in editorial PR. @ben-allen could you look at your latest spec text and figure out how to address #192 ? |
ben-allen
force-pushed
the
FrankYFTang-patch-2
branch
from
3abe0ec
to
958b255
Compare
|
Updated to set |
|
This PR implemented what the TG2 agreed change and got merged. I think we need someone to bring this PR to the next TG1 to got official consensus for the change inside Stage 3. |
|
@FrankYFTang My bad -- I thought we already had TG1 consensus on the previous version. Will add to agenda for next TG1. |
Open
|
This has reach TC39 consesus on 2024-10-09 meeting |
ben-allen
added a commit
to ben-allen/test262
that referenced
this pull request
Oct 15, 2024
… unit values while using digital style Grouping separators suppressed in this situation. See tc39/proposal-intl-duration-format/pull/198
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Oct 16, 2024
tc39/proposal-intl-duration-format#198 Bug: 42201655 Change-Id: I12ddd696406efaf9f1b8e849a3ab16251cf741ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5807717 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#96640}
ptomato
pushed a commit
to ben-allen/test262
that referenced
this pull request
Oct 30, 2024
… unit values while using digital style Grouping separators suppressed in this situation. See tc39/proposal-intl-duration-format/pull/198
ptomato
pushed a commit
to tc39/test262
that referenced
this pull request
Oct 30, 2024
… unit values while using digital style Grouping separators suppressed in this situation. See tc39/proposal-intl-duration-format/pull/198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #192