Bugfix: Display negative sign on leading numeric-style zeroes #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm tentatively thinking this is a bugfix rather than a normative change, though I've requested time on the plenary agenda in case others tell me it's normative. thoughts? @ryzokuken @gibson042 |
|
Achieved consensus at July 2024 plenary |
ben-allen
added
consensus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix:
FormatNumericUnitspreviously incorrectly dropped the negative sign when:"numeric"or"2-digit"hour or minute valueThis adds tests for these conditions to
FormatNumericUnits.fixes #204