Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeekInfoOfLocale need to convert loc.[[FirstDayOfWeek]] to number before return #82

Closed
FrankYFTang opened this issue Jul 9, 2024 · 1 comment · Fixed by #83
Closed

Comments

@FrankYFTang
Copy link
Collaborator

This is reported by @trflynn89 in #79
I copy his report below:

Hey @FrankYFTang - While implementing this, I came across a small issue. I think WeekInfoOfLocale needs to be updated to match the [[FirstDayOfWeek]] changes. [[FirstDayOfWeek]] can now be an arbitrary string, but steps 4-5 of WeekInfoOfLocale state:

4. Let fw be loc.[[FirstDayOfWeek]].
5. If fw is not undefined, then
    a. Set r.[[FirstDay]] to fw.

Where r.[[FirstDay]] is an "Integer value between 1 and 7". So I think there needs to be a step to convert fw from a string to an integer here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants