Normative: Fix WeekInfoOfLocale #83
Conversation
FrankYFTang
changed the title
locale.html
Outdated
| 1. Let _fw_ be _loc_.[[FirstDayOfWeek]]. | ||
| 1. Let _ca_ be _loc_.[[Calendar]]. | ||
| 1. If _ca_ is *"iso8601"*, then | ||
| 1. Set _r_.[[FirstDay]] to *"mon"*. |
There was a problem hiding this comment.
[[FirstDay]] is an integer - should this be set to 1 instead?
| 1. Set _r_.[[FirstDay]] to *"mon"*. | ||
| 1. Set _r_.[[MinimalDays]] to *4*. | ||
| 1. Let _fws_ be _loc_.[[FirstDayOfWeek]]. | ||
| 1. Let _fw_ be !StringToWeekdayValue(_fws_). |
There was a problem hiding this comment.
Is the ! necessary for calling an AO that cannot throw?
|
@anba @sffc @ben-allen @trflynn89 It will be nice if you all can review and comments before our July 18 , 2024 Thursday TC39 TG 2 meeting. |
locale.html
Outdated
| 1. Let _r_ be a record whose fields are defined by <emu-xref href="#table-locale-weekinfo-record"></emu-xref>, with values based on _locale_. | ||
| 1. Let _fw_ be _loc_.[[FirstDayOfWeek]]. | ||
| 1. Let _languageId_ be the longest prefix of _locale_ matched by the <code>unicode_language_id</code> Unicode locale nonterminal. | ||
| 1. Let _r_ be a record whose fields are defined by <emu-xref href="#table-locale-weekinfo-record"></emu-xref>, with values based on _languageId_. |
locale.html
Outdated
| @@ -172,8 +195,14 @@ <h1>WeekInfoOfLocale ( _loc_ )</h1> | |||
| <emu-alg> | |||
| 1. Let _locale_ be _loc_.[[Locale]]. | |||
| 1. Assert: _locale_ matches the `unicode_locale_id` production. | |||
| 1. Let _r_ be a record whose fields are defined by <emu-xref href="#table-locale-weekinfo-record"></emu-xref>, with values based on _locale_. | |||
| 1. Let _fw_ be _loc_.[[FirstDayOfWeek]]. | |||
| 1. Let _languageId_ be the longest prefix of _locale_ matched by the <code>unicode_language_id</code> Unicode locale nonterminal. | |||
There was a problem hiding this comment.
First-day-of-week could still depend on -u-ca, I think.
|
@anba in the 2024-07-18 TG2 we discuss and people express concern about the patch you proposed. So I will revert that patch from this PR and open another issue to discuss that part for our next meeting |
FrankYFTang
force-pushed
the
fixWeekInfoOfLocale
branch
from
5e3c32c
to
b22a2db
Compare
|
I revert @anba's suggestion from the branch and force push it to this PR so the current PR is without that part. |
|
Remove the "Also fix #30 to explicit set firstDay to "mon" and and minimumDays to 4 if "ca" is "iso8601" " from comments and remove the 8601 handling since it may conflict with the rg issue. |
|
The PR reach consensus in TG1 2024-7-30 . update the PR and keep the ca / rg resolution vague so the action will not conflict wtih rg. merged |
|
we may have an ICU bug need to fix about the rg/ca resolution to reflect example on https://unicode.org/reports/tr35/tr35-dates.html#first-day-overrides should return |
Fix #82 so so firstDay will return number
@anba @sffc @ben-allen @trflynn89