Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't support an iterator for the fillers #11

Merged
merged 2 commits into from
Jan 4, 2024
Merged

don't support an iterator for the fillers #11

merged 2 commits into from
Jan 4, 2024

Conversation

michaelficarra
Copy link
Member

Fixes #6. Not sure this is an improvement. It is Iterator.zip after all.

spec.emu Outdated Show resolved Hide resolved
@michaelficarra michaelficarra merged commit cb2b4b8 into main Jan 4, 2024
1 check passed
@michaelficarra michaelficarra deleted the GH-6 branch January 4, 2024 19:16
@bakkot
Copy link
Collaborator

bakkot commented Jan 4, 2024

This is definitely an improvement. Iterator.zip means it zips iterators, not that every input is an iterator. By analogy, Promise.all doesn't await its argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fillers does not need to support providing an iterator
2 participants