This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
add missing ! on CreateDataProperty #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rbuckton
reviewed
Jul 20, 2019
| @@ -34,7 +34,7 @@ <h1><ins>FromMatchOptions ( _Options_ )</ins></h1> | |||
| 1. Assert: _Options_ is a MatchOptions Record. | |||
| 1. Let _obj_ be ObjectCreate(%ObjectPrototype%). | |||
| 1. Assert: _obj_ is an extensible ordinary object with no own properties. | |||
| 1. Perform CreateDataProperty(_obj_, `"capture"`, _Options_.[[Capture]]). | |||
| 1. Perform ! CreateDataProperty(_obj_, `"capture"`, _Options_.[[Capture]]). | |||
There was a problem hiding this comment.
Is it better to do ! CreateDataProperty and then later Assert that it returns true, or do ! CreateDataPropertyOrThrow, which basically combines both?
There was a problem hiding this comment.
The latter seems much better, good call!
There was a problem hiding this comment.
I've seen both used that way in the spec, so there may be places calling ! CreateDataProperty and not checking for true currently.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.