This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
Editorial: annotate modification to params #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly specify the value that should be used when optional parameters are not provided. Update some function signatures to highlight the modifications included in this proposal. Additionally, update the signature of the SharedArrayBuffer constructor to reflect a recent change in ECMA262 [1]. [1] tc39/ecma262#2393
syg
approved these changes
Jul 15, 2021
spec.html
Outdated
| <p>When the `ArrayBuffer` function is called with argument _length_<ins> and optional argument _options_</ins>, the following steps are taken:</p> | ||
| <emu-alg> | ||
| 1. If NewTarget is *undefined*, throw a *TypeError* exception. | ||
| 1. Let _byteLength_ be ? ToIndex(_length_). | ||
| 1. <ins>If _options_ is not present, set _options_ to *undefined*.</ins> |
There was a problem hiding this comment.
I don't think this step, or the similar one in SAB, is necessary. Not present optional parameters are already undefined.
jugglinmike
changed the title
|
Right you are. I got confused by the spec's use of this pattern for abstract operations. I've updated the pull request's name, and I can do the same to the commit title by force-pushing to this branch at your request (though you may need to do that when merging from the github.com UI). |
syg
approved these changes
Jul 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly specify the value that should be used when optional
parameters are not provided. Update some function signatures to
highlight the modifications included in this proposal. Additionally,
update the signature of the SharedArrayBuffer constructor to reflect a
recent change in ECMA262 [1].
[1] tc39/ecma262#2393