Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddDate: CreateTemporalDate is fallible #2891

Open
anba opened this issue Jun 7, 2024 · 0 comments
Open

AddDate: CreateTemporalDate is fallible #2891

anba opened this issue Jun 7, 2024 · 0 comments
Assignees
@ptomato

Comments

@anba
Copy link
Contributor

anba commented Jun 7, 2024

Step 9:

Return ! CreateTemporalDate(result.[[Year]], result.[[Month]], result.[[Day]], calendarRec.[[Receiver]]).

CreateTemporalDate is fallible.

https://github.com/tc39/test262/blob/main/test/built-ins/Temporal/ZonedDateTime/prototype/until/roundingincrement-addition-out-of-range.js executes the fallible case.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 27, 2024
@anba
Bug 1903963 - Part 2: Add missing valid date-time check to AddDate. r…
a95c807 
…=spidermonkey-reviewers,dminor

tc39/proposal-temporal#2891

Depends on D214499

Differential Revision: https://phabricator.services.mozilla.com/D214500
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Jun 27, 2024
@anba
Bug 1903963 - Part 2: Add missing valid date-time check to AddDate. r…
b8df29a 
…=spidermonkey-reviewers,dminor

tc39/proposal-temporal#2891

Depends on D214499

Differential Revision: https://phabricator.services.mozilla.com/D214500
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Jun 28, 2024
@anba
Bug 1903963 - Part 2: Add missing valid date-time check to AddDate. r…
16394e6 
…=spidermonkey-reviewers,dminor

tc39/proposal-temporal#2891

Depends on D214499

Differential Revision: https://phabricator.services.mozilla.com/D214500
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Jul 1, 2024
@marco-c
Bug 1903963 - Part 2: Add missing valid date-time check to AddDate. r…
812f056 
…=spidermonkey-reviewers,dminor

tc39/proposal-temporal#2891

Depends on D214499

Differential Revision: https://phabricator.services.mozilla.com/D214500

UltraBlame original commit: 19219cc6f22aa322d6eda61a7400ac80e2fbbe7b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jul 1, 2024
@marco-c
Bug 1903963 - Part 2: Add missing valid date-time check to AddDate. r…
6169c30 
…=spidermonkey-reviewers,dminor

tc39/proposal-temporal#2891

Depends on D214499

Differential Revision: https://phabricator.services.mozilla.com/D214500

UltraBlame original commit: 19219cc6f22aa322d6eda61a7400ac80e2fbbe7b
@ptomato ptomato self-assigned this Jul 24, 2024
ptomato added a commit that referenced this issue Jul 24, 2024
@ptomato
Editorial: CreateTemporalDate in AddDate is fallible
725001c 
There is already a test262 case that tests throwing here:
test/built-ins/Temporal/ZonedDateTime/prototype/until/roundingincrement-addition-out-of-range.js
Thanks to Anba for spotting this.

Closes: #2891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba