Normative: Merge proposal-canonical-tz Stage 3 into Temporal #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2633 +/- ##
==========================================
+ Coverage 95.94% 96.03% +0.09%
==========================================
Files 20 20
Lines 11542 11563 +21
Branches 2193 2204 +11
==========================================
+ Hits 11074 11105 +31
+ Misses 404 394 -10
Partials 64 64
|
justingrant
changed the title
justingrant
force-pushed
the
canonical-tz-stage3
branch
2 times, most recently
from
9d4b697
to
bfd8b67
Compare
linusg
reviewed
Jul 19, 2023
justingrant
force-pushed
the
canonical-tz-stage3
branch
2 times, most recently
from
2f9b4c4
to
329535c
Compare
gibson042
approved these changes
Jul 19, 2023
justingrant
force-pushed
the
canonical-tz-stage3
branch
3 times, most recently
from
25946d2
to
d9af603
Compare
gibson042
reviewed
Jul 19, 2023
gibson042
approved these changes
Jul 19, 2023
justingrant
force-pushed
the
canonical-tz-stage3
branch
4 times, most recently
from
985aa4e
to
add0641
Compare
6 tasks
|
All of Richard's review comments are resolved. There's no rush to merge this PR this week, so I'm planning to wait for @ptomato's review (after he's back from vacation next week) before merging. @sffc, I wasn't planning to wait for your review to merge this, but would love to get your feedback if you have any! |
sffc
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Really like how this spec has worked out! Great job @justingrant
justingrant
force-pushed
the
canonical-tz-stage3
branch
4 times, most recently
from
787ee96
to
775cdc6
Compare
gibson042
reviewed
Jul 21, 2023
justingrant
force-pushed
the
canonical-tz-stage3
branch
2 times, most recently
from
441239a
to
2020dca
Compare
justingrant
force-pushed
the
canonical-tz-stage3
branch
5 times, most recently
from
a5c10dc
to
176ee52
Compare
This was referenced Jul 27, 2023
ptomato
approved these changes
Aug 7, 2023
ptomato
force-pushed
the
canonical-tz-stage3
branch
from
176ee52
to
1930b00
Compare
|
Combining the time zone canonicalization proposal into Temporal was part of the conclusions for the time zone canonicalization proposal's stage 3 advancement at the TC39 meeting in July 2023. Tests are in tc39/test262#3837, which I've now reviewed. I understand this PR was only waiting on me, so I'll merge it now. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 7, 2023
…=mgaudet Implement the changes from <tc39/proposal-temporal#2633>. Differential Revision: https://phabricator.services.mozilla.com/D189772
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 7, 2023
…=mgaudet Implement the changes from <tc39/proposal-temporal#2633>. Differential Revision: https://phabricator.services.mozilla.com/D189772
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 8, 2023
…=mgaudet Implement the changes from <tc39/proposal-temporal#2633>. Differential Revision: https://phabricator.services.mozilla.com/D189772 UltraBlame original commit: 71b919fe3767226aba654ed1bf4df099c27c4eed
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 8, 2023
…=mgaudet Implement the changes from <tc39/proposal-temporal#2633>. Differential Revision: https://phabricator.services.mozilla.com/D189772 UltraBlame original commit: 71b919fe3767226aba654ed1bf4df099c27c4eed
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 8, 2023
…=mgaudet Implement the changes from <tc39/proposal-temporal#2633>. Differential Revision: https://phabricator.services.mozilla.com/D189772 UltraBlame original commit: 71b919fe3767226aba654ed1bf4df099c27c4eed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/tc39/proposal-canonical-tz reached Stage 3 at the July 2023 TC39 meeting. At that meeting, the committee decided that proposal-canonical-tz, instead of continuing as a standalone proposal, should be merged into Temporal Stage 3.
This PR does this merging! 🚀🚀🚀
Tests are at tc39/test262#3837.
cc @gibson042