Fix getOffsetStringFor docs for sub-minute offsets #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justingrant
added
documentation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2674 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 20 20
Lines 11984 11984
Branches 2227 2227
=======================================
Hits 11532 11532
Misses 389 389
Partials 63 63 ☔ View full report in Codecov by Sentry. |
ptomato
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2673 to clarify that sub-minute time zone offsets will be output by
Temporal.TimeZone.prototype.getOffsetStringForwhen the offset isn't aligned on a minute boundary.Note that sub-minute offsets are only allowed for IANA and custom zones, and are disallowed for offset time zones per #2607.