Editorial improvements #2689
Merged
Editorial improvements #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Set here would traverse the prototype chain to find an existing property descriptor, but _fields_ doesn't have a prototype chain because it's already asserted to have a null prototype. Therefore using CreateDataPropertyOrThrow should be exactly equivalent, but simpler. Thanks to Anba for spotting this. Closes: #2683
Thanks to Anba for spotting this. Closes: #2684
Brings all of the structured headers for these AOs up to date with the latest best practices, adding structured headers in the cases where the headers were not yet structured.
Spotted by Anba. _options_ is already an Object or undefined in all of these operations, and GetOptionsObject cannot throw on those inputs. Closes: #2686
...if the precalculated offset comes from GetOffsetNanosecondsFor and is guaranteed to be less than a 24-hour day, that is. Thanks to Anba for spotting this. Adjust call sites to assert there is no abrupt completion, and add an assertion to GetPlainDateTimeFor to ensure it is only called with correct offsets. Closes: #2687
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2689 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 20 20
Lines 11986 11986
Branches 2227 2227
=======================================
Hits 11534 11534
Misses 389 389
Partials 63 63 ☔ View full report in Codecov by Sentry. |
Ms2ger
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to @anba for catching these.
Closes: #2683
Closes: #2684
Closes: #2686
Closes: #2687