Polyfill: Refine valueOf exception message (again) #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justingrant
added
non-prod-polyfill
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2691 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 20 20
Lines 11986 11987 +1
Branches 2227 2227
=======================================
+ Hits 11534 11535 +1
Misses 389 389
Partials 63 63
☔ View full report in Codecov by Sentry. |
Continue where #2667 left off by further clarifying this error message and fixing a mistake where `+foo` was treated as a string coercion, not the number coercion that it is.
justingrant
force-pushed
the
justingrant-patch-1
branch
from
86ce21a to
73c8de1
Compare
Ms2ger
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue where #2667 left off by further clarifying this error message and fixing a mistake where
+foowas treated as a string coercion, not the number coercion that it is.