Fix handling of overflow returns to BalancePossiblyInfiniteDurationRelative #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12wrigja
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
==========================================
- Coverage 96.33% 96.30% -0.03%
==========================================
Files 20 20
Lines 12211 12205 -6
Branches 2274 2276 +2
==========================================
- Hits 11763 11754 -9
- Misses 390 393 +3
Partials 58 58
☔ View full report in Codecov by Sentry. |
ptomato
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Thanks for spotting this, it's correct.
Normally I would try to add a test262 test, since apparently this is a coverage gap. But in #2612, hopefully landing soon, we are removing the possibility for a duration to overflow in this function (because you just won't be able to construct durations that could overflow here.) So I think in this case it's not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current spec for
BalancePossiblyInfinteTimeDurationRelativeincludes early-returning the overflow values, but this is not present in the polyfill code.This seems to have been introduced in 0547d29.