Various editorial changes #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two methods in this list were incorrectly in there, since they don't have the parameter. Two methods were missing from the list. Closes: #2717
This guideline is already in the docs, for use by custom calendars. It would be useful to have in the spec for built-in calendars, to ensure consistent behaviour. See: #2706
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2719 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 20 20
Lines 12196 12196
Branches 2274 2274
=======================================
Hits 11752 11752
Misses 389 389
Partials 55 55 ☔ View full report in Codecov by Sentry. |
Ms2ger
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes non-normative part of #2706
Closes: #2714
Closes: #2717