Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ecmarkup #2764

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Bump ecmarkup #2764

merged 3 commits into from
Jan 31, 2024

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jan 31, 2024

Ecmarkup now has extremely basic, strictly local, very permissive typechecking, which can detect when you are calling an AO with a literal value which doesn't make sense given the declared type of that AO (for some literal values and declared types).

It catches a couple typos here, which I fixed. There's one issue I didn't fix because I don't know what it's intended to be, which is that this line passes false to a place which accepts either ~negative~ or ~positive~.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f3e997) 96.61% compared to head (ba09d4c) 96.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2764   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          23       23           
  Lines       12229    12229           
  Branches     2281     2281           
=======================================
  Hits        11815    11815           
  Misses        354      354           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bakkot Thanks, much appreciated!

That false used to be passed to a boolean parameter called "isNegative", so I'll assume that it should now be ~positive~. I'll tack on a commit fixing that, and then merge this.

Used to be a Boolean parameter called "isNegative".
@ptomato ptomato merged commit 40ca575 into tc39:main Jan 31, 2024
9 checks passed
@bakkot bakkot deleted the bump-ecmarkup branch January 31, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants