Normative: Partial stack of removals #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 tasks
Ms2ger
approved these changes
Jun 13, 2024
Closes: #2849 Co-Authored-By: Richard Gibson <richard.gibson@gmail.com>
ptomato
force-pushed
the
partial-stack-of-removals
branch
from
7d4e66a
to
2650536
Compare
|
Thanks for the quick review. (Note, this was also already reviewed by other Temporal champions while on the branch that was shared in the TC39 presentation.) |
This was referenced Jul 11, 2024
sosukesuzuki
added a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Aug 18, 2024
https://bugs.webkit.org/show_bug.cgi?id=278285 Reviewed by NOBODY (OOPS!). At the TC39 meeting on 2024-06, it was decied to obsolete several Temporal APIs[1][2]. This patch removes the following for Temporal.Instant: - Temporal.Instant.fromEpochSeconds - Temporal.Instant.fromEpochMicroseconds - Temporal.Instant.prototype.epochSeconds - Temporal.Instant.prototype.epochMicroseconds [1]: https://github.com/tc39/notes/blob/main/meetings/2024-06/june-12.md#temporal-stage-3-update-and-scope-reduction [2]: tc39/proposal-temporal#2895 * JSTests/stress/date-to-temporal-instant.js: (shouldBe): * JSTests/stress/temporal-instant.js: (shouldBe): (instants.forEach): * Source/JavaScriptCore/runtime/ISO8601.h: * Source/JavaScriptCore/runtime/TemporalInstant.cpp: * Source/JavaScriptCore/runtime/TemporalInstant.h: * Source/JavaScriptCore/runtime/TemporalInstantConstructor.cpp: * Source/JavaScriptCore/runtime/TemporalInstantPrototype.cpp:
webkit-commit-queue
pushed a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Aug 18, 2024
https://bugs.webkit.org/show_bug.cgi?id=278285 Reviewed by Yusuke Suzuki. At the TC39 meeting on 2024-06, it was decied to obsolete several Temporal APIs[1][2]. This patch removes the following for Temporal.Instant: - Temporal.Instant.fromEpochSeconds - Temporal.Instant.fromEpochMicroseconds - Temporal.Instant.prototype.epochSeconds - Temporal.Instant.prototype.epochMicroseconds [1]: https://github.com/tc39/notes/blob/main/meetings/2024-06/june-12.md#temporal-stage-3-update-and-scope-reduction [2]: tc39/proposal-temporal#2895 * JSTests/stress/date-to-temporal-instant.js: (shouldBe): * JSTests/stress/temporal-instant.js: (shouldBe): (instants.forEach): * Source/JavaScriptCore/runtime/ISO8601.h: * Source/JavaScriptCore/runtime/TemporalInstant.cpp: * Source/JavaScriptCore/runtime/TemporalInstant.h: * Source/JavaScriptCore/runtime/TemporalInstantConstructor.cpp: * Source/JavaScriptCore/runtime/TemporalInstantPrototype.cpp: Canonical link: https://commits.webkit.org/282400@main
sosukesuzuki
added a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Sep 8, 2024
…ainDateTime https://bugs.webkit.org/show_bug.cgi?id=279312 Reviewed by NOBODY (OOPS!). Due to changes in Temporal from July 2024, several methods have become obsolete[1]. We have already removed the methods of Temporal.Instant that were marked obsolete[2]. This patch removes the following methods from Temporal.PlainTime and Temporal.PlainDateTime: - Temporal.PlainTime.prototype.toPlainDateTime - Temporal.PlainDateTime.prototype.withPlainDate Although there are other methods slated for removal in the Temporal changes[1], we had not yet implemented those methods. [1]: tc39/proposal-temporal#2895 [2]: https://commits.webkit.org/282400@main * JSTests/stress/temporal-plaindatetime.js: * JSTests/stress/temporal-plaintime.js: (shouldBe.String.Temporal.PlainTime.from): * Source/JavaScriptCore/runtime/TemporalPlainDateTimePrototype.cpp: * Source/JavaScriptCore/runtime/TemporalPlainTimePrototype.cpp:
webkit-commit-queue
pushed a commit
to sosukesuzuki/WebKit
that referenced
this pull request
Sep 8, 2024
…ainDateTime https://bugs.webkit.org/show_bug.cgi?id=279312 Reviewed by Yusuke Suzuki. Due to changes in Temporal from July 2024, several methods have become obsolete[1]. We have already removed the methods of Temporal.Instant that were marked obsolete[2]. This patch removes the following methods from Temporal.PlainTime and Temporal.PlainDateTime: - Temporal.PlainTime.prototype.toPlainDateTime - Temporal.PlainDateTime.prototype.withPlainDate Although there are other methods slated for removal in the Temporal changes[1], we had not yet implemented those methods. [1]: tc39/proposal-temporal#2895 [2]: https://commits.webkit.org/282400@main * JSTests/stress/temporal-plaindatetime.js: * JSTests/stress/temporal-plaintime.js: (shouldBe.String.Temporal.PlainTime.from): * Source/JavaScriptCore/runtime/TemporalPlainDateTimePrototype.cpp: * Source/JavaScriptCore/runtime/TemporalPlainTimePrototype.cpp: Canonical link: https://commits.webkit.org/283315@main
michael-markl
added a commit
to michael-markl/proposal-temporal
that referenced
this pull request
Oct 21, 2024
Fixes broken description caused by the PR tc39#2895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an implementation of part of the slate of API removals that reached consensus in the TC39 meeting of 2024-06-12. This consists of all removals except for calendars and time zones and things related to them such as getISOFields, which will follow in a later PR.
This PR contains documentation updates, removals from the spec text, removals from the reference code, removals from the suggested TypeScript definitions, and adjustments of the cookbook examples.
Here is what's removed exactly:
Tests are in tc39/test262#4108.
Closes: #2846, #2847, #2848, #2849