Editorial: Next batch of editorial issues #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferenceISODateTime asserts that the ISO Date-Time Records passed to it are within limits. Previously there were two places where this was not guaranteed to be the case. Add checks that throw RangeError so the assertion is not hit. Closes: #3015
The default formatter would look for a property called _repr_, which does not exist, and therefore would be confusingly formatted as "undefined". Instead, delegate to the original Intl.DateTimeFormat's util.inspect output.
In a94a793 the desired behaviour when formatting Temporal objects was accidentally applied to formatting Date objects. So new Date().toLocaleDateString([], { hour: "numeric" }); would result in bestFormat being null, and according to the type assertion of the Intl.DateTimeFormat [[DateTimeFormat]] internal slot, that is not possible. Checking that _inherit_ = ~relevant~ here ensures the new behaviour is only applied to Temporal objects, and the type assertion is not hit. See: #3049
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3053 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 21 21
Lines 9705 9716 +11
Branches 1742 1742
=======================================
+ Hits 9291 9302 +11
Misses 363 363
Partials 51 51 ☔ View full report in Codecov by Sentry. |
|
cc @anba @trflynn89 |
Some of the DateTimeFormat internal slots may contain null instead of a DateTime Format Record, if no relevant fields were given. That needs to be reflected in the return type of this operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new Date().toLocale{Date,Time,}String()(see The chosen best format inIntl.DateTimeFormatis potentially null #3049)