Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Missing changes for Intl.PluralRules #64

Closed
anba opened this issue Jul 19, 2019 · 2 comments
Closed

Missing changes for Intl.PluralRules #64

anba opened this issue Jul 19, 2019 · 2 comments
Labels
editorial Issue involves spec text with no behavior change

Comments

@anba
Copy link

anba commented Jul 19, 2019

SetNumberFormatDigitOptions is also called from InitializePluralRule, so we need to have some additional changes for `Intl.PluralRules:

  • [[RoundingType]] needs to be added to PluralRules objects.
  • [[Notation]] either needs to be added to PluralRules objects, too. Or the notation style needs to be passed through as an extra parameter to SetNumberFormatDigitOptions instead of reading it from intlObj.[[Notation]].
@sffc sffc added the editorial Issue involves spec text with no behavior change label Nov 12, 2019
@longlho
Copy link
Contributor

longlho commented Dec 19, 2019

Several operations like ToRawFixed have also been changed. Will this be reflected in Intl.PluralRules as well?

sffc added a commit that referenced this issue Dec 20, 2019
@sffc
Adding PluralRules spec to proposal repository. See #64
e241841
sffc added a commit that referenced this issue Dec 20, 2019
@sffc
Updating PluralRules spec text without changing behavior. See #64
226a608
@sffc sffc mentioned this issue Jan 5, 2020
Closed
@sffc
Copy link
Collaborator

sffc commented Jan 10, 2020

The editorial issues have been fixed in #80. I filed tc39/ecma402#399 to follow up about adding support for notation plural rules.

@sffc sffc closed this as completed Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
editorial Issue involves spec text with no behavior change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@longlho @sffc @anba