-
Notifications
You must be signed in to change notification settings - Fork 14
Deprecate x_google_ignoreList in favor of ignoreList, remove Known Extensions #19
Conversation
Not sure about the "2024" part exactly, but otherwise looks good! |
I wasn't sure about that part either. The full migration plan would look like this:
But I didn't want this feature to take up too much of the spec space, so rather than spell out a migration plan in detail I gave a vague timeline that I think is realistic. |
Thank you so much for submitting this! My first thought was to remove the What do you think about that? |
This is how it was done for |
I could delete the Known Extensions section. I'm not aware of anyone using x_google_lineCount. |
I'm all up for removing it entirely tbh. As you mentioned, |
Sorry, just checking on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. I'd either split it into two commits, or update the PR title accordingly, as it does more than just updating ignoreList
now.
@jkup anything else needed here? |
Thank you for doing this! |
SHA: 83ed289 Reason: push, by jkup Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Hi @EricSL :) Quick question: do you work for a company that's part of TC39? If not, could you sign TC39's IPR form (see https://github.com/tc39/ecma262/blob/main/CONTRIBUTING.md#required-legal-agreements for more info)? Unfortunately there is a bug in our CI scripts and they didn't catch it until the PR has been merged. |
I work for Google and I see we are on this list: https://www.ecma-international.org/tc39-royalty-free-technical-committee-members/ so I believe there's no problem? |
Yes then it's ok :) We can add an exception to the IPR check script so that it does not fail on your contribution (or we can ask to Google's delegates if it's possible to onboard you as a TC39 delegate, if you prefer). |
I'd prefer the exception. |
Making a proposal to deprecate
x_google_ignoreList
in favor of a new field namedignoreList
. I am also open to making the namethirdParty
if people would prefer that, as it would name it according to what the information means rather than what a consumer might do with it.If this change is agreed on and there is buy-in from someone at Mozilla, I can make the implementation change for Chromium.