-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable import-assertions tests #3780
Comments
I was curious if we had any tests for other features that had been demoted to stage 2, so this motivated me to go clean up the features.txt file: #3782 There are still tests in the corpus for cleanupSome which was split off at stage 2, as well as import assertions. Also, this made me realize that import assertions being at stage 2 leaves the status of JSON modules somewhat unclear. I guess JSON modules are technically still stage 3 but temporarily unimplementable because the language lacks the syntax with which to express them? Because of this, my preference would be to leave the import assertions tests as they are, and just recommend that implementations filter out the |
Given that communication with prose isn't as reliable, my preference would be to remove them and immediately open up the revert PR. I agree that JSON modules is currently unimplementable until import assertions becomes stage 3 again. |
Import assertions have become import attributes, which have now reached stage 3. Can we disable tests for import assertions now? |
The proposal still includes https://tc39.es/proposal-import-attributes/#sec-deprecated-assert-keyword-for-import-attributes |
As it gets stage-2 and syntax change can be possible, we should disable import-assertions tests.
The text was updated successfully, but these errors were encountered: