Remove import-assertions tests #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Yeah it's time to do this.
Can you also remove it from
Lines 34 to 38 in 5e57a79
import-assertions in the whole repo to make sure we are not missing anything else?
Jon4t4n
force-pushed
the
remove-import-assertion
branch
from
257fdab
to
b7c7cc8
Compare
Generated by running `./make.py clean` and `./make.py`
ptomato
force-pushed
the
remove-import-assertion
branch
from
b7c7cc8
to
ec09ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the
assertversion was removed in tc39/proposal-import-attributes#161, so I think we can get rid of the import-assertions tests now.Closes #3780