Various test cases for cross-browser compliance bugs #1532

anba · 2018-04-25T17:43:12Z

Some test cases where I observed cross-browser compatibility issues in the past.

ljharb · 2018-04-25T17:53:29Z

It’d be helpful for es6-shim for the API cases if you could comment somehow (in the PR is fine) which engines/browsers fail these tests.

anba · 2018-04-25T18:25:12Z

@ljharb

Versions:
V8: b49206ded97c4eaac7c273ce004d840a0185d40e
Chakra: 60b52c56bec9e156b55b558f6d8a7ef7c6ef4810
JSC: r230952

Array/prototype/{filter,map,slice,splice}/target-array-with-non-writable-property.js -> JSC, Chakra
Array/prototype/indexOf/calls-only-has-on-prototype-after-length-zeroed.js -> JSC, Chakra
Array/prototype/lastIndexOf/calls-only-has-on-prototype-after-length-zeroed.js -> JSC, Chakra, V8
Array/prototype/splice/property-traps-order-with-species.js -> JSC, Chakra, V8
Function/prototype/bind/length-exceeds-int32.js -> JSC, Chakra
Object/assign/strings-and-symbol-order.js -> Chakra, V8
Object/keys/property-traps-order-with-proxied-array.js -> JSC, V8
Array/prototype/toLocaleString/calls-toLocaleString-number-elements.js -> Chakra, V8
TypedArray/prototype/toLocaleString/calls-toLocaleString-number-elements.js -> JSC, Chakra, V8

SpiderMonkey issues (only the ones I still remember):
https://bugzilla.mozilla.org/show_bug.cgi?id=1121938
https://bugzilla.mozilla.org/show_bug.cgi?id=1130636
https://bugzilla.mozilla.org/show_bug.cgi?id=1323825
https://bugzilla.mozilla.org/show_bug.cgi?id=1364363

leobalter · 2018-04-25T18:53:26Z

test/built-ins/Array/prototype/splice/property-traps-order-with-species.js

+
+a.constructor[Symbol.species] = function(len) {
+    return new Proxy(new Array(len), new Proxy({}, {
+        get(t, pk, r) {


wow!!! this is great!

rwaldron · 2018-04-26T15:33:50Z

test/annexB/language/function-code/block-decl-nested-blocks-with-fun-decl.js

+    assert.sameValue(f(), 1);
+}
+
+g();


This appears to duplicate https://github.com/tc39/test262/blob/master/test/annexB/language/function-code/block-decl-func-existing-fn-no-init.js

The new test case has an extra block-statement, which is not present in the linked one. And the linked test succeeds in SM/V8/JSC/Chakra, whereas the new test case only succeeds in V8.

Excellent, thanks for the clarification

rwaldron · 2018-04-26T15:49:42Z

...aration/function-declaration-attempt-to-redeclare-with-var-declaration-nested-in-function.js

+            var f;
+        }
+    }
+}


This appears to duplicate https://github.com/tc39/test262/blob/master/test/language/block-scope/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-var-declaration.js

Also an extra block-statement which makes it different from the existing one. (The existing test case passes in V8/SM and fails in JSC/Chakra, the new one only passes in SM.)

rwaldron · 2018-04-26T15:52:03Z

...age/expressions/async-arrow-function/await-as-param-ident-nested-arrow-parameter-position.js

+
+throw "Test262: This statement should not be evaluated.";
+
+async(a = await => {}) => {};


This appears to duplicate https://github.com/tc39/test262/blob/master/test/language/expressions/async-arrow-function/early-errors-arrow-await-in-formals-default.js

The new test case passes only in Chakra and SM, whereas the existing one passes in all four engines. (The new test case tries to ensure arrow functions with await as the arrow-parameter are correctly handled in async arrow function parameters.)

rwaldron · 2018-04-26T15:55:46Z

test/language/expressions/async-arrow-function/await-as-param-nested-arrow-body-position.js

+
+throw "Test262: This statement should not be evaluated.";
+
+async() => { (a = await/r/g) => {} };


rwaldron · 2018-04-26T15:55:53Z

.../language/expressions/async-arrow-function/await-as-param-nested-arrow-parameter-position.js

+
+throw "Test262: This statement should not be evaluated.";
+
+async(a = (await) => {}) => {};


rwaldron · 2018-04-26T15:55:57Z

...uage/expressions/async-arrow-function/await-as-param-rest-nested-arrow-parameter-position.js

+
+throw "Test262: This statement should not be evaluated.";
+
+async(a = (...await) => {}) => {};


rwaldron · 2018-04-26T16:02:49Z

test/language/expressions/async-arrow-function/escaped-async-line-terminator.js

+  are to appear in a script exactly as written. All terminal symbol code points
+  specified in this way are to be understood as the appropriate Unicode code points
+  from the Basic Latin range, as opposed to any similar-looking code points from
+  other Unicode ranges.


This description and info aren't correct for this test.

Given:

async [no LineTerminator here] AsyncArrowBindingIdentifier

The comment in the actual test source is good:

Throws ReferenceError because reference for "async" cannot be resolved.

Hmm, maybe we should cite both sections? 14.7 for the overall grammar of async arrow functions and 5.1.5 to make clear that \u0061sync shouldn't actually be considered as an async arrow function in the first place.

rwaldron · 2018-04-26T17:35:53Z

test/language/expressions/class/class-name-ident-let-escaped.js

+
+  It is a Syntax Error if this phrase is contained in strict mode code and the
+  StringValue of IdentifierName is: "implements", "interface", "let", "package",
+  "private", "protected", "public", "static", or "yield".


I'd like to add this section: https://tc39.github.io/ecma262/#sec-strict-mode-code, but you don't have to do it if it's a pain (I don't mind doing it in a follow up)

rwaldron · 2018-04-26T17:37:06Z

test/language/statements/class/class-name-ident-await.js

+info: |
+  12.1.1 Static Semantics: Early Errors
+
+  IdentifierReference : yield


rwaldron · 2018-04-26T17:37:09Z

test/language/statements/class/class-name-ident-await-module.js

+info: |
+  12.1.1 Static Semantics: Early Errors
+
+  IdentifierReference : yield


leobalter · 2018-05-03T17:43:28Z

LGTM, waiting for @rwaldron to confirm the changes after his review.

anba · 2018-05-03T18:06:04Z

I've folded the updates in original patch, because it only updated yaml code.

Complete diff.

diff --git a/test/language/expressions/async-arrow-function/escaped-async-line-terminator.js b/test/language/expressions/async-arrow-function/escaped-async-line-terminator.js
index 0182fac..ee3a7a0 100644
--- a/test/language/expressions/async-arrow-function/escaped-async-line-terminator.js
+++ b/test/language/expressions/async-arrow-function/escaped-async-line-terminator.js
@@ -2,10 +2,16 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: sec-grammar-notation
+esid: sec-async-arrow-function-definitions
 description: >
-  The `async` contextual keyword must not contain Unicode escape sequences.
+  Escaped "async" followed by a line-terminator is not misinterpreted as an AsyncArrowFunction.
 info: |
+  14.7 Async Function Definitions
+
+  async [no LineTerminator here] AsyncArrowBindingIdentifier[?Yield] [no LineTerminator here] => AsyncConciseBody[?In]
+
+  5.1.5 Grammar Notation
+
   Terminal symbols of the lexical, RegExp, and numeric string grammars are shown
   in fixed width font, both in the productions of the grammars and throughout this
   specification whenever the text directly refers to such a terminal symbol. These
diff --git a/test/language/expressions/class/class-name-ident-let-escaped.js b/test/language/expressions/class/class-name-ident-let-escaped.js
index 42faf32..e9beb52 100644
--- a/test/language/expressions/class/class-name-ident-let-escaped.js
+++ b/test/language/expressions/class/class-name-ident-let-escaped.js
@@ -13,6 +13,10 @@ info: |
   It is a Syntax Error if this phrase is contained in strict mode code and the
   StringValue of IdentifierName is: "implements", "interface", "let", "package",
   "private", "protected", "public", "static", or "yield".
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/expressions/class/class-name-ident-let.js b/test/language/expressions/class/class-name-ident-let.js
index 2224fa3..d08620f 100644
--- a/test/language/expressions/class/class-name-ident-let.js
+++ b/test/language/expressions/class/class-name-ident-let.js
@@ -13,6 +13,10 @@ info: |
   It is a Syntax Error if this phrase is contained in strict mode code and the
   StringValue of IdentifierName is: "implements", "interface", "let", "package",
   "private", "protected", "public", "static", or "yield".
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/expressions/class/class-name-ident-static-escaped.js b/test/language/expressions/class/class-name-ident-static-escaped.js
index fb519a1..8680e69 100644
--- a/test/language/expressions/class/class-name-ident-static-escaped.js
+++ b/test/language/expressions/class/class-name-ident-static-escaped.js
@@ -13,6 +13,10 @@ info: |
   It is a Syntax Error if this phrase is contained in strict mode code and the
   StringValue of IdentifierName is: "implements", "interface", "let", "package",
   "private", "protected", "public", "static", or "yield".
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/expressions/class/class-name-ident-static.js b/test/language/expressions/class/class-name-ident-static.js
index 1b8c23f..a914e59 100644
--- a/test/language/expressions/class/class-name-ident-static.js
+++ b/test/language/expressions/class/class-name-ident-static.js
@@ -13,6 +13,10 @@ info: |
   It is a Syntax Error if this phrase is contained in strict mode code and the
   StringValue of IdentifierName is: "implements", "interface", "let", "package",
   "private", "protected", "public", "static", or "yield".
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/expressions/class/class-name-ident-yield-escaped.js b/test/language/expressions/class/class-name-ident-yield-escaped.js
index 445fe29..6adf12d 100644
--- a/test/language/expressions/class/class-name-ident-yield-escaped.js
+++ b/test/language/expressions/class/class-name-ident-yield-escaped.js
@@ -13,6 +13,10 @@ info: |
   It is a Syntax Error if this phrase is contained in strict mode code and the
   StringValue of IdentifierName is: "implements", "interface", "let", "package",
   "private", "protected", "public", "static", or "yield".
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/expressions/class/class-name-ident-yield.js b/test/language/expressions/class/class-name-ident-yield.js
index 4c69296..ecc3f44 100644
--- a/test/language/expressions/class/class-name-ident-yield.js
+++ b/test/language/expressions/class/class-name-ident-yield.js
@@ -11,6 +11,10 @@ info: |
   IdentifierReference : yield
 
   It is a Syntax Error if the code matched by this production is contained in strict mode code.
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/statements/class/class-name-ident-await-module.js b/test/language/statements/class/class-name-ident-await-module.js
index 6353ac2..ec6af34 100644
--- a/test/language/statements/class/class-name-ident-await-module.js
+++ b/test/language/statements/class/class-name-ident-await-module.js
@@ -8,7 +8,7 @@ description: >
 info: |
   12.1.1 Static Semantics: Early Errors
 
-  IdentifierReference : yield
+  IdentifierReference : await
 
   It is a Syntax Error if the goal symbol of the syntactic grammar is Module.
 negative:
diff --git a/test/language/statements/class/class-name-ident-await.js b/test/language/statements/class/class-name-ident-await.js
index 5deb9af..0237382 100644
--- a/test/language/statements/class/class-name-ident-await.js
+++ b/test/language/statements/class/class-name-ident-await.js
@@ -8,7 +8,7 @@ description: >
 info: |
   12.1.1 Static Semantics: Early Errors
 
-  IdentifierReference : yield
+  IdentifierReference : await
 
   It is a Syntax Error if the goal symbol of the syntactic grammar is Module.
 ---*/
diff --git a/test/language/statements/class/class-name-ident-let-escaped.js b/test/language/statements/class/class-name-ident-let-escaped.js
index b344a1a..eb54d47 100644
--- a/test/language/statements/class/class-name-ident-let-escaped.js
+++ b/test/language/statements/class/class-name-ident-let-escaped.js
@@ -13,6 +13,10 @@ info: |
   It is a Syntax Error if this phrase is contained in strict mode code and the
   StringValue of IdentifierName is: "implements", "interface", "let", "package",
   "private", "protected", "public", "static", or "yield".
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/statements/class/class-name-ident-let.js b/test/language/statements/class/class-name-ident-let.js
index 0e819dc..62da254 100644
--- a/test/language/statements/class/class-name-ident-let.js
+++ b/test/language/statements/class/class-name-ident-let.js
@@ -13,6 +13,10 @@ info: |
   It is a Syntax Error if this phrase is contained in strict mode code and the
   StringValue of IdentifierName is: "implements", "interface", "let", "package",
   "private", "protected", "public", "static", or "yield".
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/statements/class/class-name-ident-static-escaped.js b/test/language/statements/class/class-name-ident-static-escaped.js
index e1fc8cc..fe1e1e7 100644
--- a/test/language/statements/class/class-name-ident-static-escaped.js
+++ b/test/language/statements/class/class-name-ident-static-escaped.js
@@ -13,6 +13,10 @@ info: |
   It is a Syntax Error if this phrase is contained in strict mode code and the
   StringValue of IdentifierName is: "implements", "interface", "let", "package",
   "private", "protected", "public", "static", or "yield".
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/statements/class/class-name-ident-static.js b/test/language/statements/class/class-name-ident-static.js
index 4548996..43b7c9c 100644
--- a/test/language/statements/class/class-name-ident-static.js
+++ b/test/language/statements/class/class-name-ident-static.js
@@ -13,6 +13,10 @@ info: |
   It is a Syntax Error if this phrase is contained in strict mode code and the
   StringValue of IdentifierName is: "implements", "interface", "let", "package",
   "private", "protected", "public", "static", or "yield".
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/statements/class/class-name-ident-yield-escaped.js b/test/language/statements/class/class-name-ident-yield-escaped.js
index a94089b..e2992b5 100644
--- a/test/language/statements/class/class-name-ident-yield-escaped.js
+++ b/test/language/statements/class/class-name-ident-yield-escaped.js
@@ -13,6 +13,10 @@ info: |
   It is a Syntax Error if this phrase is contained in strict mode code and the
   StringValue of IdentifierName is: "implements", "interface", "let", "package",
   "private", "protected", "public", "static", or "yield".
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError
diff --git a/test/language/statements/class/class-name-ident-yield.js b/test/language/statements/class/class-name-ident-yield.js
index 6bbb9c0..6ef5165 100644
--- a/test/language/statements/class/class-name-ident-yield.js
+++ b/test/language/statements/class/class-name-ident-yield.js
@@ -11,6 +11,10 @@ info: |
   IdentifierReference : yield
 
   It is a Syntax Error if the code matched by this production is contained in strict mode code.
+
+  10.2.1 Strict Mode Code
+
+  All parts of a ClassDeclaration or a ClassExpression are strict mode code.
 negative:
   phase: parse
   type: SyntaxError

rwaldron · 2018-05-03T18:19:37Z

Thanks!

leobalter reviewed Apr 25, 2018

View reviewed changes

ljharb mentioned this pull request Apr 25, 2018

Investigate newly reported browser incompatibilities paulmillr/es6-shim#448

Open

rwaldron requested changes Apr 26, 2018

View reviewed changes

Various test cases for cross-browser compliance bugs

b552dad

anba force-pushed the compat-new branch from f726db8 to b552dad Compare May 3, 2018 16:32

leobalter approved these changes May 3, 2018

View reviewed changes

leobalter assigned rwaldron May 3, 2018

rwaldron approved these changes May 3, 2018

View reviewed changes

rwaldron merged commit 3b7a456 into tc39:master May 3, 2018

anba deleted the compat-new branch June 25, 2020 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various test cases for cross-browser compliance bugs #1532

Various test cases for cross-browser compliance bugs #1532

anba commented Apr 25, 2018

ljharb commented Apr 25, 2018

anba commented Apr 25, 2018 •

edited

Loading

leobalter Apr 25, 2018

rwaldron Apr 25, 2018

rwaldron Apr 26, 2018

anba Apr 27, 2018

rwaldron Apr 27, 2018

rwaldron Apr 26, 2018

anba Apr 27, 2018

rwaldron Apr 27, 2018

rwaldron Apr 26, 2018

anba Apr 27, 2018

rwaldron Apr 27, 2018

rwaldron Apr 26, 2018

rwaldron Apr 26, 2018

rwaldron Apr 26, 2018

rwaldron Apr 26, 2018

anba Apr 27, 2018

rwaldron Apr 26, 2018

rwaldron Apr 26, 2018

rwaldron Apr 26, 2018

leobalter commented May 3, 2018

anba commented May 3, 2018

rwaldron commented May 3, 2018


		throw "Test262: This statement should not be evaluated.";

		async(a = await => {}) => {};


		throw "Test262: This statement should not be evaluated.";

		async() => { (a = await/r/g) => {} };


		throw "Test262: This statement should not be evaluated.";

		async(a = (await) => {}) => {};


		throw "Test262: This statement should not be evaluated.";

		async(a = (...await) => {}) => {};

Various test cases for cross-browser compliance bugs #1532

Various test cases for cross-browser compliance bugs #1532

Conversation

anba commented Apr 25, 2018

ljharb commented Apr 25, 2018

anba commented Apr 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leobalter commented May 3, 2018

anba commented May 3, 2018

rwaldron commented May 3, 2018

anba commented Apr 25, 2018 •

edited

Loading