Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flags for new.target #1648

Closed

Conversation

IgnoredAmbience
Copy link
Contributor

@IgnoredAmbience IgnoredAmbience commented Jul 24, 2018

Add feature flags for new.target

Commit additionally removes the arrow-function feature for
test/language/eval-code/direct/new.target-fn.js as it is not testing
arrow-functions, but they are mentioned in the preamble.

Additionally removed the `arrow-function` feature for
test/language/eval-code/direct/new.target-fn.js as it is not testing
arrow-functions, but they are mentioned in the preamble.
@IgnoredAmbience
Copy link
Contributor Author

I'm confused as to why the build has failed, CONTRIBUTING.md says:

Tests expressed with this convention are built automatically following the source files' acceptance into the project. Patches should not include assets built from these sources.

But the CI build has failed with:

$ ./tools/scripts/ci_build.sh
Running target: build
> /home/travis/virtualenv/python2.7.14/bin/python tools/generation/generator.py create --out test src
New changes were found after re-generating the tests.
Please, read the documentation on procedurally generated tests
https://github.com/tc39/test262/blob/master/CONTRIBUTING.md#procedurally-generated-tests
The command "./tools/scripts/ci_build.sh" exited with 1.

These two statements seem contradictory?

@rwaldron
Copy link
Contributor

No problem, I pulled this and regenerated the generated tests. I've opened a PR at: #1649 (which has your original commit in it)

@rwaldron rwaldron closed this Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants