Tests for proposal-well-formed-stringify #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
force-pushed
the
proposal-well-formed-stringify
branch
from
abec281
to
3e020dd
Compare
|
The proposal advanced to stage 3 at the September 2018 TC39 meeting. Please remove the “awaiting stage 3” label. |
| @@ -3,11 +3,15 @@ | |||
|
|
|||
| /*--- | |||
| es5id: 15.12.3_4-1-2 | |||
| description: JSON.stringify a circular object throws a TypeError | |||
| description: JSON.stringify a indirectly circular object throws a error | |||
There was a problem hiding this comment.
2×, i.e.
JSON.stringify on an indirectly circular object throws an error
| var char_to_json = { | ||
| '"': '\\"', | ||
| "\\": "\\\\", | ||
| "\x00": "\\u0000", |
There was a problem hiding this comment.
\x00 could be \0 (it’s not an octal escape sequence)
There was a problem hiding this comment.
I addressed the grammar nits, but left this \x00 for internal consistency with the following properties.
There was a problem hiding this comment.
That's fine. It was either the preceding property (\\) or the following ones.
mathiasbynens
approved these changes
Sep 29, 2018
|
This seems good to go. @rwaldron @leobalter Would it be possible to prioritize this PR over others please? V8 is looking to ship this and we'd like to wait until there are official (and merged) Test262 tests. |
rwaldron
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/tc39/proposal-well-formed-stringify
Prevent
JSON.stringifyfrom returning ill-formed Unicode strings.Includes moderate refactoring of other
JSON.stringifytests, which can be separated out upon request.