Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RegExp property escape tests per Unicode v13.0.0 #2526

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

mathiasbynens
Copy link
Member

Copy link
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like Unicode is the largest source of breaking changes in JS :)

@leobalter
Copy link
Member

BTW, good to keep track of Unicode 13 adoption here: https://test262.report/features/regexp-unicode-property-escapes/built-ins/RegExp/property-escapes

@leobalter leobalter merged commit 25c9e33 into tc39:master Mar 11, 2020
@mathiasbynens mathiasbynens deleted the unicode-13-property-escapes branch March 11, 2020 21:19
@jirkamarsik
Copy link

I see that this new update includes aliases for the emoji properties (EComp for Emoji_Component, EMod for Emoji_Modifier, EBase for Emoji_Modifier_Base, EPres for Emoji_Presentation and ExtPict for Extended_Pictographic). The tests now check that implementations support these short-hand aliases. However, the spec currently forbids such aliases (see Table 56).

Is it the plan to update the spec to include these aliases or were they added here accidentally?

@mathiasbynens
Copy link
Member Author

@jirkamarsik Good catch! These aliases haven't yet been added to the spec. Patch: tc39/ecma262#1939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants