Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test ProxyCreate with revoked target and handler #2548

Merged
merged 4 commits into from
Mar 30, 2020
Merged

Test ProxyCreate with revoked target and handler #2548

merged 4 commits into from
Mar 30, 2020

Conversation

shvaikalesh
Copy link
Member

@rwaldron
Copy link
Contributor

@bathos can you take a look?

@bathos
Copy link

bathos commented Mar 29, 2020 •
edited
Loading

@rwaldron I’m out of the loop re: any further discussion which might have taken place regarding this change, but this does LGTM.

I could see value in also testing for typeof revoked === 'function', where the revoked proxy’s target was another revoked proxy which had [[Call]].

@shvaikalesh shvaikalesh force-pushed the proxy-create-revoked-target-handler branch from d4397ed to f1b025c Compare March 30, 2020 06:37
@rwaldron rwaldron merged commit 9ccd3a7 into tc39:master Mar 30, 2020
@shvaikalesh shvaikalesh mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaldron rwaldron rwaldron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shvaikalesh @rwaldron @bathos