New NativeFunction tests #2716
Merged
New NativeFunction tests #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
force-pushed
the
function-syntax
branch
7 times, most recently
from
f66f11e
to
4e7f377
Compare
ExE-Boss
reviewed
Jul 26, 2020
devsnek
force-pushed
the
function-syntax
branch
3 times, most recently
from
33e8f1d
to
405d896
Compare
test/built-ins/Function/prototype/toString/built-in-function-object.js
Outdated
Show resolved
Hide resolved
devsnek
force-pushed
the
function-syntax
branch
5 times, most recently
from
66f2328
to
1becd0c
Compare
|
@michaelficarra r? please |
|
@leobalter Not sure what your comment means. Current status is we're waiting on @devsnek to add documentation related to the RegExp generation process. |
|
sorry @michaelficarra I was just asking you for a review, assuming the changes would be good enough for a new round. Thanks for the update. |
|
@michaelficarra look alright now? |
michaelficarra
approved these changes
Jul 31, 2020
rwaldron
reviewed
Aug 4, 2020
| @@ -8,452 +8,283 @@ defines: [WellKnownIntrinsicObjects] | |||
|
|
|||
| const WellKnownIntrinsicObjects = [ | |||
| { | |||
| intrinsicName: "%Array%", | |||
| globalNameOrSource: "Array" | |||
There was a problem hiding this comment.
I don't see any value in renaming these. The names that they have are derived from the column header in the spec.
There was a problem hiding this comment.
it was less of renaming and more of recreating the whole thing from scratch. i can of course put the names back if you feel strongly about it.
|
@syg heads up for failures on V8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tc39/ecma262#1948